-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emitter support and reactive dependency updates #1853
Emitter support and reactive dependency updates #1853
Conversation
Rework the emitter support
...ava/io/quarkus/smallrye/reactivemessaging/deployment/SmallRyeReactiveMessagingProcessor.java
Show resolved
Hide resolved
...ava/io/quarkus/smallrye/reactivemessaging/deployment/SmallRyeReactiveMessagingProcessor.java
Outdated
Show resolved
Hide resolved
Use constants for DOTNAME
@mkouba Code updated. |
.asClass() | ||
.methods()) { | ||
ClassInfo ci = bean.getTarget() | ||
.orElseThrow(() -> new IllegalStateException("Target expected")).asClass(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If bean.isClassBean()==true
the target is never empty.
if (annotationStore.hasAnnotation(method, NAME_INCOMING) | ||
|| annotationStore.hasAnnotation(method, NAME_OUTGOING)) { | ||
// TODO: validate method params and return type? | ||
mediatorMethods.produce(new MediatorBuildItem(bean, method)); | ||
LOGGER.debugf("Found mediator business method %s declared on %s", method, bean); | ||
} | ||
} | ||
|
||
for (FieldInfo field : ci.fields()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this means that we only support field injection. In fact, we can simply iterate over all injection points:
for (InjectionPointInfo injectionPoint : validationContext.get(Key.INJECTION_POINTS)) {
// TODO
}
I'll try to update this PR in a moment...
@cescoffier Pls review my updates... |
ConsumeEvent.blocking
, new axle method)